selectrum: partially fix selectrum-repeat issue
- doesn't restore selection upon repeat, might be upstream issue - document some bugs/todos
This commit is contained in:
parent
23b4dfa521
commit
157a6c5c4b
2 changed files with 13 additions and 5 deletions
|
@ -26,9 +26,18 @@ https://github.com/raxod502/selectrum/issues/491
|
||||||
** TODO ~(defadvice! +orderless-match-with-one-face..~ causes lexical error
|
** TODO ~(defadvice! +orderless-match-with-one-face..~ causes lexical error
|
||||||
probably caused by some doomism
|
probably caused by some doomism
|
||||||
https://github.com/oantolin/orderless/issues/41
|
https://github.com/oantolin/orderless/issues/41
|
||||||
** TODO =SPC '= doesn't work on =SPC /=
|
** TODO ~selectrum-repeat~ Issues
|
||||||
Something in the ~selectrum-last-command~ logic breaks down. Maybe the fact that
|
Unlike Ivy, ~selectrum-repeat~ doesn't restore the position of the selection in
|
||||||
~+selectrum-file-search~ is defined with ~cl-defun~?
|
the completion buffer. Seems to be reproduced in ~emacs -Q~. If so, create
|
||||||
|
upstream selectrum issue.
|
||||||
|
** TODO go over definition of ~+selectrum-file-search~
|
||||||
|
check if anything else there needs to be cleaned up.
|
||||||
|
** TODO Embark export window buffer switching logic
|
||||||
|
If we export bookmarks, grep session, or ~find-file~ session, when pressing
|
||||||
|
enter, it opens the new buffer in another window rather than the main one, even
|
||||||
|
though at least the bookmark function ostensibly uses
|
||||||
|
~pop-to-buffer-same-window~. Ivy gets the window switched in the bookmarks and
|
||||||
|
grep case due to a custom ivy occur window switching function.
|
||||||
** TODO ~orderless+initialism~ doesn't work for some reason
|
** TODO ~orderless+initialism~ doesn't work for some reason
|
||||||
See https://github.com/oantolin/orderless/issues/54.
|
See https://github.com/oantolin/orderless/issues/54.
|
||||||
Narrowed it down to the fact that it works if ~selectrum-mode~ is off, but
|
Narrowed it down to the fact that it works if ~selectrum-mode~ is off, but
|
||||||
|
|
|
@ -23,8 +23,7 @@ one face."
|
||||||
(user-error "Couldn't find ripgrep in your PATH"))
|
(user-error "Couldn't find ripgrep in your PATH"))
|
||||||
(require 'consult)
|
(require 'consult)
|
||||||
(setq deactivate-mark t)
|
(setq deactivate-mark t)
|
||||||
(let* ((this-command 'consult--grep)
|
(let* ((project-root (or (doom-project-root) default-directory))
|
||||||
(project-root (or (doom-project-root) default-directory))
|
|
||||||
(directory (or in project-root))
|
(directory (or in project-root))
|
||||||
(args (split-string
|
(args (split-string
|
||||||
(string-trim
|
(string-trim
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue