emenel/doomemacs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

refactor: remove unused core variables

Browse source 
doom-debug-p and doom-interactive-p have always been intentionally
redundant, because changing the variables they replaced had other
side-effects, which made writing tests for them difficult. Since our
new (yet unpublished) tests lean heavily toward integration testing more
than unit testing, this becomes an implementation detail.

And doom-init-p's only use was refactor out at some point in the past,
so it's no longer used.

Also done to reduce Doom's footprint, in general.
This commit is contained in:
Henrik Lissner 2022-06-24 21:15:31 +02:00
parent 74cc541597
commit 14b2395424
No known key found for this signature in database
GPG key ID: B60957CA074D39A3
22 changed files with 55 additions and 76 deletions
Download patch file Download diff file Expand all files Collapse all files

6
core/core-cli-lib.el
View file

@ -1009,7 +1009,7 @@ shown."
(seconds (- duration (* hours 60 60) (* minutes 60)))
(standard-output
(if (and (/= doom-cli--exit-code 0)
(or doom-debug-p
(or init-file-debug
(eq (doom-cli-prop cli :benchmark) t)
(and (eq (doom-cli-prop cli :benchmark :null) :null)
(not (doom-cli-context-pipe-p context 'out t))
@ -1100,7 +1100,7 @@ Emacs' batch library lacks an implementation of the exec system call."
(insert "#!/usr/bin/env sh\n"
"trap _doomcleanup EXIT\n"
"_doomcleanup() {\n"
" rm -" (if doom-debug-p "v" "") "f "
" rm -" (if init-file-debug "v" "") "f "
(combine-and-quote-strings (delq nil (list script-file context-file)))
"\n}\n"
"_doomrun() {\n " command "\n}\n"
@ -1195,7 +1195,7 @@ ARGS are options passed to less. If DOOMPAGER is set, ARGS are ignored."
(append (if doom-print-backend '("-r")) ; process ANSI codes
(or (delq nil args) '("+g"))))
(shell-quote-argument tmpfile)
(if doom-debug-p "v" "")
(if init-file-debug "v" "")
(shell-quote-argument tmpfile))
context)))))