From 0f4328058cb51f4ace7864e19a7bc589bdeca022 Mon Sep 17 00:00:00 2001 From: Henrik Lissner Date: Thu, 15 Aug 2024 23:19:49 -0400 Subject: [PATCH] fix: restrict find-function-search-for-symbol advice to Emacs 29 The issue this advice fixes are fixed at some point in 30.x. --- lisp/doom-editor.el | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/doom-editor.el b/lisp/doom-editor.el index fc04fd7f6..fa873c870 100644 --- a/lisp/doom-editor.el +++ b/lisp/doom-editor.el @@ -577,8 +577,8 @@ files, so this replace calls to `pp' with the much faster `prin1'." (lambda (button) (helpful-variable (button-get button 'apropos-symbol)))))) - (when (> emacs-major-version 28) - ;; REVIEW This should be reported upstream to Emacs. + ;; DEPRECATED: Remove when support for 29 is dropped. + (when (= emacs-major-version 29) (defadvice! doom--find-function-search-for-symbol-save-excursion-a (fn &rest args) "Suppress cursor movement by `find-function-search-for-symbol'.