General, minor refactor & feedback revision

core/core-dispatcher.el

@@ -632,10 +632,12 @@ If MODULES is specified (a list of module strings, e.g. \"lang/php\"), those are
 byte-compiled. Otherwise, all enabled modules are byte-compiled, including Doom
 core. It always ignores unit tests and files with `no-byte-compile' enabled.
 
-Doom was designed to benefit from byte-compilation, but the process may take a
-while. Also, while your config files are byte-compiled, changes to them will not
-take effect! Use `doom//clean-byte-compiled-files' or `make clean' to remove
-these files.
+WARNING: byte-compilation yields marginal gains and makes debugging new issues
+difficult. It is recommended you don't use it unless you understand the
+reprecussions.
+
+Use `doom//clean-byte-compiled-files' or `make clean' to reverse
+byte-compilation.
 
 If RECOMPILE-P is non-nil, only recompile out-of-date files."
   (interactive

core/core-modules.el

@@ -274,8 +274,7 @@ to least)."
 (defmacro def-package! (name &rest plist)
   "A thin wrapper around `use-package'."
   ;; Ignore package if NAME is in `doom-disabled-packages'
-  (when (and (memq name (bound-and-true-p doom-disabled-packages))
-             (not (memq :disabled plist)))
+  (when (memq name (bound-and-true-p doom-disabled-packages))
     (setq plist `(:disabled t ,@plist)))
   ;; If byte-compiling, ignore this package if it doesn't meet the condition.
   ;; This avoids false-positive load errors.

core/core-packages.el

@@ -227,8 +227,7 @@ elsewhere."
                                doom-private-dir)
       (setq plist (plist-put plist :private t)))
     `(progn
-       ,(when (and pkg-pin t)
-          `(map-put package-pinned-packages ',name ,pkg-pin))
+       ,(if pkg-pin `(map-put package-pinned-packages ',name ,pkg-pin))
        (map-put doom-packages ',name ',plist)
        (not (memq ',name doom-disabled-packages)))))
 

core/core.el

@@ -174,6 +174,7 @@ this, you'll get stuttering and random freezes) and resets
  history-length 500
  make-backup-files nil  ; don't create backup~ files
  ;; `use-package'
+ use-package-compute-statistics doom-debug-mode
  use-package-verbose doom-debug-mode
  use-package-minimum-reported-time (if doom-debug-mode 0 0.1)
  ;; byte compilation

core/templates/QUICKSTART_INTRO

@@ -3,7 +3,7 @@ Before you doom yourself, there are a few things you should know:
 1. If you use GUI Emacs, run `M-x all-the-icons-install-fonts` so you don't get
    weird symbols all over the place.
 
-2. When you edit ~/.doom.d/init.el or modify modules, run:
+2. Whenever you edit ~/.doom.d/init.el or modify modules, run:
 
      bin/doom refresh
 
@@ -15,8 +15,8 @@ Before you doom yourself, there are a few things you should know:
 
      bin/doom doctor
 
-   It will diagnose common issues with your environment and setup, and may give
-   you clues about what is wrong.
+   This will diagnose common issues with your environment and setup, and may
+   give you clues about what is wrong.
 
 4. To update doom, run
 
@@ -24,7 +24,7 @@ Before you doom yourself, there are a few things you should know:
 
    Doing it any other way will require you run `bin/doom refresh` otherwise,
 
-5. Check out `bin/doom help` to see what else it can do (it is also safe to add
-   ~/.emacs.d/bin to your PATH).
+5. Check out `bin/doom help` to see what else it can do (it is recommended you
+   add ~/.emacs.d/bin to your PATH).
 
 Have fun!